-
-
Notifications
You must be signed in to change notification settings - Fork 420
London | 26-ITP-JAN | Kayanat Suleman | Sprint 2 | Form Controls #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
London | 26-ITP-JAN | Kayanat Suleman | Sprint 2 | Form Controls #1086
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is free of syntax error and well indented. Well done!
I only have a challenge for you (see the inline comment).
|
Changes look good. Do you know what the regular expression |
|
Hi cjyuan, thank you for the additional question. Upon doing some research I found that this is a regex expression which helps to describe what patterns of text are allowed/disallowed. I understand that the "." matches any single character, the "*" means any characters, length or nothing, the "\S" means any non-whitespace character - so the rule becomes - whatever input the user enters must contain at least one non-whitespace character somewhere. I then tested this solution using devtools console to see if I only entered " ", what would happen - this failed as it does not contain a non-space character, the second test was "Ka" - this passes and finally " K " also passes as it satisfies the rule. |

Learners, PR Template
Self checklist
Changelist
fieldsetandlegendQuestions
None yet, happy to make any amendments. Thank you for reviewing.